[From nobody Fri Mar 27 15:40:27 2009 From: Shri Borde <Shri.Borde@microsoft.com> To: IronRuby External Code Reviewers <irbrev@microsoft.com> CC: "'ironruby-core@rubyforge.org'" <ironruby-core@rubyforge.org> Date: Thu, 26 Mar 2009 16:34:59 -0700 Subject: Review: Marshal bug Thread-Topic: Review: Marshal bug Thread-Index: Acmua3o0EyerzWVQR3uOXAvX7gwa0g== Message-ID: <D8A955813EF2A0419964D362B9A5F6C8CBB3F576D9@NA-EXMSG-C104.redmond.corp.microsoft.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: multipart/alternative; boundary="_000_D8A955813EF2A0419964D362B9A5F6C8CBB3F576D9NAEXMSGC104re_" MIME-Version: 1.0 --_000_D8A955813EF2A0419964D362B9A5F6C8CBB3F576D9NAEXMSGC104re_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable GitDiff.bat a90a89465f3b9c178507f83e4797481463989059 119b056332b270164eaf2b= 1f9cd2956387e38636 http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e3= 8636 YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp '2009-03-22 00:00:00\s\t'") is allowed Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe is not in the path File.expand_path("~") should throw ArgumentError is HOME is not set * Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Eng= ine/BaseConstructor.cs<http://github.com/shri/ironruby/commit/119b056332b27= 0164eaf2b1f9cd2956387e38636#diff-0> * Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Eng= ine/Scanner.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2= b1f9cd2956387e38636#diff-1> * Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_= path_spec.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1= f9cd2956387e38636#diff-2> * Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixt= ures/marshal_data.rb<http://github.com/shri/ironruby/commit/119b056332b2701= 64eaf2b1f9cd2956387e38636#diff-3> * Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load= _spec.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd= 2956387e38636#diff-4> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOp= s.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956= 387e38636#diff-5> * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marsha= l.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956= 387e38636#diff-6> * Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat<http://github.com/s= hri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7> * Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat<http://github.com/s= hri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8> * Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat<http://github.com= /shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9> * Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat<http://github.com/= shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10> * Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat<http://github.com/= shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11> * Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat<http://github.com/sh= ri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12> Thanks, Shri --_000_D8A955813EF2A0419964D362B9A5F6C8CBB3F576D9NAEXMSGC104re_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:x=3D"urn:schemas-microsoft-com:office:excel" xmlns:p=3D"urn:schemas-m= icrosoft-com:office:powerpoint" xmlns:a=3D"urn:schemas-microsoft-com:office= :access" xmlns:dt=3D"uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s=3D"= uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs=3D"urn:schemas-microsof= t-com:rowset" xmlns:z=3D"#RowsetSchema" xmlns:b=3D"urn:schemas-microsoft-co= m:office:publisher" xmlns:ss=3D"urn:schemas-microsoft-com:office:spreadshee= t" xmlns:c=3D"urn:schemas-microsoft-com:office:component:spreadsheet" xmlns= :odc=3D"urn:schemas-microsoft-com:office:odc" xmlns:oa=3D"urn:schemas-micro= soft-com:office:activation" xmlns:html=3D"http://www.w3.org/TR/REC-html40" = xmlns:q=3D"http://schemas.xmlsoap.org/soap/envelope/" xmlns:D=3D"DAV:" xmln= s:mt=3D"http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2=3D= "http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ois=3D"http://sc= hemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir=3D"http://schemas.micro= soft.com/sharepoint/soap/directory/" xmlns:ds=3D"http://www.w3.org/2000/09/= xmldsig#" xmlns:dsp=3D"http://schemas.microsoft.com/sharepoint/dsp" xmlns:u= dc=3D"http://schemas.microsoft.com/data/udc" xmlns:xsd=3D"http://www.w3.org= /2001/XMLSchema" xmlns:sub=3D"http://schemas.microsoft.com/sharepoint/soap/= 2002/1/alerts/" xmlns:ec=3D"http://www.w3.org/2001/04/xmlenc#" xmlns:sp=3D"= http://schemas.microsoft.com/sharepoint/" xmlns:sps=3D"http://schemas.micro= soft.com/sharepoint/soap/" xmlns:xsi=3D"http://www.w3.org/2001/XMLSchema-in= stance" xmlns:udcs=3D"http://schemas.microsoft.com/data/udc/soap" xmlns:udc= xf=3D"http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p=3D"http:/= /schemas.microsoft.com/data/udc/parttopart" xmlns:wf=3D"http://schemas.micr= osoft.com/sharepoint/soap/workflow/" xmlns:dsss=3D"http://schemas.microsoft= .com/office/2006/digsig-setup" xmlns:dssi=3D"http://schemas.microsoft.com/o= ffice/2006/digsig" xmlns:mdssi=3D"http://schemas.openxmlformats.org/package= /2006/digital-signature" xmlns:mver=3D"http://schemas.openxmlformats.org/ma= rkup-compatibility/2006" xmlns:m=3D"http://schemas.microsoft.com/office/200= 4/12/omml" xmlns:mrels=3D"http://schemas.openxmlformats.org/package/2006/re= lationships" xmlns:spwp=3D"http://microsoft.com/sharepoint/webpartpages" xm= lns:ex12t=3D"http://schemas.microsoft.com/exchange/services/2006/types" xml= ns:ex12m=3D"http://schemas.microsoft.com/exchange/services/2006/messages" x= mlns:pptsl=3D"http://schemas.microsoft.com/sharepoint/soap/SlideLibrary/" x= mlns:spsl=3D"http://microsoft.com/webservices/SharePointPortalServer/Publis= hedLinksService" xmlns:Z=3D"urn:schemas-microsoft-com:" xmlns:st=3D"&#1;" x= mlns=3D"http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 12 (filtered medium)"> <style> <!-- /* Font Definitions */ @font-face {font-family:Wingdings; panose-1:5 0 0 0 0 0 0 0 0 0;} @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0in; margin-bottom:.0001pt; font-size:11.0pt; font-family:"Calibri","sans-serif";} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed {mso-style-priority:99; color:purple; text-decoration:underline;} pre {mso-style-priority:99; mso-style-link:"HTML Preformatted Char"; margin:0in; margin-bottom:.0001pt; font-size:10.0pt; font-family:"Courier New";} span.EmailStyle17 {mso-style-type:personal-compose; font-family:"Calibri","sans-serif"; color:windowtext;} span.HTMLPreformattedChar {mso-style-name:"HTML Preformatted Char"; mso-style-priority:99; mso-style-link:"HTML Preformatted"; font-family:"Courier New";} .MsoChpDefault {mso-style-type:export-only;} @page Section1 {size:8.5in 11.0in; margin:1.0in 1.0in 1.0in 1.0in;} div.Section1 {page:Section1;} /* List Definitions */ @list l0 {mso-list-id:1299801198; mso-list-template-ids:1371731676;} @list l0:level1 {mso-level-number-format:bullet; mso-level-text:\F0B7; mso-level-tab-stop:.5in; mso-level-number-position:left; text-indent:-.25in; mso-ansi-font-size:10.0pt; font-family:Symbol;} ol {margin-bottom:0in;} ul {margin-bottom:0in;} --> </style><!--[if gte mso 9]><xml> <o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" /> </xml><![endif]--><!--[if gte mso 9]><xml> <o:shapelayout v:ext=3D"edit"> <o:idmap v:ext=3D"edit" data=3D"1" /> </o:shapelayout></xml><![endif]--> </head> <body lang=3D"EN-US" link=3D"blue" vlink=3D"purple"> <div class=3D"Section1"> <p class=3D"MsoNormal">GitDiff.bat a90a89465f3b9c178507f83e4797481463989059= 119b056332b270164eaf2b1f9cd2956387e38636<o:p></o:p></p> <p class=3D"MsoNormal"><a href=3D"http://github.com/shri/ironruby/commit/11= 9b056332b270164eaf2b1f9cd2956387e38636">http://github.com/shri/ironruby/com= mit/119b056332b270164eaf2b1f9cd2956387e38636</a><o:p></o:p></p> <p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p> <p class=3D"MsoNormal"><span lang=3D"EN" style=3D"font-size:10.0pt;font-fam= ily:&quot;Courier New&quot;">YAML should allow spaces. eg the trailing \s\t= in YAML.load(&quot;!timestamp <o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN" style=3D"font-size:10.0pt;font-fam= ily:&quot;Courier New&quot;">'2009-03-22 00:00:00\s\t'&quot;) is allowed<o:= p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN" style=3D"font-size:10.0pt;font-fam= ily:&quot;Courier New&quot;">Changed igem.bat, irake.bat, etc to work in de= v environment where ir.exe <o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN" style=3D"font-size:10.0pt;font-fam= ily:&quot;Courier New&quot;">is not in the path<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN" style=3D"font-size:10.0pt;font-fam= ily:&quot;Courier New&quot;">File.expand_path(&quot;~&quot;) should throw A= rgumentError is HOME is not set<o:p></o:p></span></p> <p class=3D"MsoNormal"><span lang=3D"EN" style=3D"font-size:12.0pt;font-fam= ily:&quot;Times New Roman&quot;,&quot;serif&quot;"><o:p>&nbsp;</o:p></span>= </p> <ul type=3D"disc"> <li class=3D"MsoNormal" style=3D"mso-margin-top-alt:auto;mso-margin-bottom-= alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-0">Merlin/External/Languages/IronRub= y/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-1">Merlin/External/Languages/IronRub= y/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-2">Merlin/External/Languages/IronRub= y/mspec/rubyspec/core/file/expand_path_spec.rb</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-3">Merlin/External/Languages/IronRub= y/mspec/rubyspec/core/marshal/fixtures/marshal_data.rb</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-4">Merlin/External/Languages/IronRub= y/mspec/rubyspec/library/yaml/load_spec.rb</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-5">Merlin/Main/Languages/Ruby/Librar= ies.LCA_RESTRICTED/Builtins/FileOps.cs</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-6">Merlin/Main/Languages/Ruby/Librar= ies.LCA_RESTRICTED/Builtins/Marshal.cs</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-7">Merlin/Main/Languages/Ruby/Script= s/bin/igem.bat</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-8">Merlin/Main/Languages/Ruby/Script= s/bin/iirb.bat</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-9">Merlin/Main/Languages/Ruby/Script= s/bin/irails.bat</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-10">Merlin/Main/Languages/Ruby/Scrip= ts/bin/irake.bat</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-11">Merlin/Main/Languages/Ruby/Scrip= ts/bin/irdoc.bat</a> <o:p></o:p></span></li><li class=3D"MsoNormal" style=3D"mso-margin-top-alt:= auto;mso-margin-bottom-alt:auto; mso-list:l0 level1 lfo1"> <span lang=3D"EN"><a href=3D"http://github.com/shri/ironruby/commit/119b056= 332b270164eaf2b1f9cd2956387e38636#diff-12">Merlin/Main/Languages/Ruby/Scrip= ts/bin/iri.bat</a> <o:p></o:p></span></li></ul> <p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p> <p class=3D"MsoNormal">Thanks,<o:p></o:p></p> <p class=3D"MsoNormal">Shri<o:p></o:p></p> <p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p> </div> </body> </html> --_000_D8A955813EF2A0419964D362B9A5F6C8CBB3F576D9NAEXMSGC104re_-- ]