<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:Consolas;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><span style='color:#1F497D'>Awesome! Ruby changes are
good (other than a typo “bidning” in a comment in HostingTests.cs </span><span
style='font-family:Wingdings;color:#1F497D'>J</span><span style='color:#1F497D'>).<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Tomas Matousek <br>
<b>Sent:</b> Tuesday, January 06, 2009 11:17 AM<br>
<b>To:</b> IronRuby External Code Reviewers; DLR Code Reviews<br>
<b>Cc:</b> ironruby-core@rubyforge.org<br>
<b>Subject:</b> Code Review: InitAndScopes6<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoPlainText>tfpt review
"/shelveset:InitAndScopes6;REDMOND\tomat"<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText><b>Outer-ring DLR changes (Hosting API implementation):<o:p></o:p></b></p>
<p class=MsoPlainText> <o:p></o:p></p>
<p class=MsoPlainText> Any code compilation/execution without explicitly
given scope should eventually call SourceUnit.Compile overload that creates a
new scope for the execution, so that a) the creation of an implicit empty scope
is implemented on a single place and b) the language can adjust compilation
based upon whether the code is executed against a scope or not (different
overloads of LanguageContext.GetCompilerOptions are called).<o:p></o:p></p>
<p class=MsoPlainText> <o:p></o:p></p>
<p class=MsoPlainText> Adds SourceUnit.Execute overload taking ErrorSink
parameter to match Compile overloads.<o:p></o:p></p>
<p class=MsoPlainText> <o:p></o:p></p>
<p class=MsoPlainText><b>Ruby changes:<o:p></o:p></b></p>
<p class=MsoPlainText> <o:p></o:p></p>
<p class=MsoPlainText> Enables sharing of Ruby top-level binding across
multiple executions against the same DLR Scope, which enables local variables
in a console implemented via DLR Hosting API.<o:p></o:p></p>
<p class=MsoPlainText> <o:p></o:p></p>
<p class=MsoPlainText> Refactors control flow handling in rules:<o:p></o:p></p>
<p class=MsoPlainText> - Methods that build rules are of two
kinds: BuildXxxNoFlow and BuildXxx, where the former produces a rule w/o
control flow and optionally stores a control flow builder delegate on
MetaObjectBuilder if CF handling is needed. The latter calls the former and if
there has been a CF builder registered applies it on the resulting meta object.
This allows to compose rules w/o CF and then apply CF handling once on the
final result.<o:p></o:p></p>
<p class=MsoPlainText> - Fixes IO#open not to dynamically
dispatch to “new”. The implementation requires the above rule
composition.<o:p></o:p></p>
<p class=MsoPlainText> <o:p></o:p></p>
<p class=MsoPlainText> Scope cleanup:<o:p></o:p></p>
<p class=MsoPlainText> - Renames GlobalScopeExtension to
RubyGlobalScope.<o:p></o:p></p>
<p class=MsoPlainText> - Removes unnecessary dependencies on
RubyScope where RubyContext is sufficient.<o:p></o:p></p>
<p class=MsoPlainText> - Replaces uses of Scope where
RubyGlobalScope is more suitable.<o:p></o:p></p>
<p class=MsoPlainText> - Removes
RubyContext.DefaultGlobalScope and adds Ruby.RequireFile taking a ScriptScope.<o:p></o:p></p>
<p class=MsoPlainText> <o:p></o:p></p>
<p class=MsoPlainText> Replaces Booleans on RubyCompilerOptions with an
enum.<o:p></o:p></p>
<p class=MsoPlainText> Fixes method definition in module_eval or
define_method.<o:p></o:p></p>
<p class=MsoPlainText> Adds /py option to unit test driver, which enables
tests dependent on IronPython.<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Tomas<o:p></o:p></p>
</div>
</body>
</html>