<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:D="DAV:" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:Z="urn:schemas-microsoft-com:" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>As much as we would love to attend more Ruby conferences (and
there are a LOT of Ruby conferences!), we really don’t have the bandwidth. So
we’re being very careful about where we go. <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>We’ll be at RubyConf this year.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Thanks,<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>-John<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> ironruby-core-bounces@rubyforge.org
[mailto:ironruby-core-bounces@rubyforge.org] <b>On Behalf Of </b>Unnikrishnan
Nair<br>
<b>Sent:</b> Wednesday, July 16, 2008 10:52 PM<br>
<b>To:</b> ironruby-core@rubyforge.org<br>
<b>Subject:</b> Re: [Ironruby-core] Code Review: unni1<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<table class=MsoNormalTable border=0 cellspacing=0 cellpadding=0>
<tr>
<td valign=top style='padding:0in 0in 0in 0in'>
<p>Jim,<o:p></o:p></p>
<p> <o:p></o:p></p>
<p>As per your comments, I have modified the code and ran against Matz Ruby
and verified the results. Yes you are correct 'nul' is same as 'NUL' as well.
I have updated the patch as well.<o:p></o:p></p>
<p> <o:p></o:p></p>
<p>Just curious, how come there is no representation of IronRuby in Lonestar
Ruby conference?<o:p></o:p></p>
<p> <o:p></o:p></p>
<p>Thanks.<o:p></o:p></p>
<p>Unni<br>
<br>
--- On <b>Wed, 7/16/08, Unnikrishnan Nair <i><ksunair@yahoo.com></i></b>
wrote:<o:p></o:p></p>
<blockquote style='border:none;border-left:solid #1010FF 1.5pt;padding:0in 0in 0in 4.0pt;
margin-left:3.75pt;margin-top:5.0pt;margin-bottom:5.0pt'>
<p class=MsoNormal style='margin-bottom:12.0pt'>From: Unnikrishnan Nair
<ksunair@yahoo.com><br>
Subject: Re: [Ironruby-core] Code Review: unni1<br>
To: ironruby-core@rubyforge.org<br>
Date: Wednesday, July 16, 2008, 10:34 AM<o:p></o:p></p>
<div id=yiv655849692>
<table class=MsoNormalTable border=0 cellspacing=0 cellpadding=0>
<tr>
<td valign=top style='padding:0in 0in 0in 0in'>
<p>yes, I will do that.<o:p></o:p></p>
<p>Thanks.<o:p></o:p></p>
<p>Unni<br>
<br>
--- On <b>Tue, 7/15/08, Jim Deville <i><jdeville@microsoft.com></i></b>
wrote:<o:p></o:p></p>
<blockquote style='border:none;border-left:solid #1010FF 1.5pt;padding:
0in 0in 0in 4.0pt;margin-left:3.75pt;margin-top:5.0pt;margin-bottom:5.0pt'>
<p class=MsoNormal style='margin-bottom:12.0pt'>From: Jim Deville
<jdeville@microsoft.com><br>
Subject: Re: [Ironruby-core] Code Review: unni1<br>
To: "ironruby-core@rubyforge.org"
<ironruby-core@rubyforge.org>, "IronRuby External Code
Reviewers" <irbrev@microsoft.com><br>
Date: Tuesday, July 15, 2008, 3:51 PM<o:p></o:p></p>
<pre>While testing this manually I discovered that CRuby treats nul and NUL as zero<o:p></o:p></pre><pre>length files, while this patch only works for NUL. Unni, can you fix that and<o:p></o:p></pre><pre>resubmit?<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>Thanks,<o:p></o:p></pre><pre><o:p> </o:p></pre><pre><o:p> </o:p></pre><pre>JD<o:p></o:p></pre><pre><o:p> </o:p></pre><pre><o:p> </o:p></pre><pre>> -----Original Message-----<o:p></o:p></pre><pre>> From: ironruby-core-bounces@rubyforge.org [mailto:ironruby-core-<o:p></o:p></pre><pre>> bounces@rubyforge.org] On Behalf Of Jim Deville<o:p></o:p></pre><pre>> Sent: Tuesday, July 15, 2008 2:31 PM<o:p></o:p></pre><pre>> To: ironruby-core@rubyforge.org; IronRuby External Code Reviewers<o:p></o:p></pre><pre>> Subject: Re: [Ironruby-core] Code Review: unni1<o:p></o:p></pre><pre>><o:p> </o:p></pre><pre>> Reviewed F2F with John<o:p></o:p></pre><pre>><o:p> </o:p></pre><pre>><o:p> </o:p></pre><pre>> JD<o:p></o:p></pre><pre>><o:p> </o:p></pre><pre>> > -----Original Message-----<o:p></o:p></pre><pre>> > From: ironruby-core-bounces@rubyforge.org [mailto:ironruby-core-<o:p></o:p></pre><pre>> > bounces@rubyforge.org] On Behalf Of Jim Deville<o:p></o:p></pre><pre>> > Sent: Tuesday, July 15, 2008 1:45 PM<o:p></o:p></pre><pre>> > To: IronRuby External Code Reviewers<o:p></o:p></pre><pre>> > Cc: ironruby-core@rubyforge.org<o:p></o:p></pre><pre>> > Subject: [Ironruby-core] Code Review: unni1<o:p></o:p></pre><pre>> ><o:p></o:p></pre><pre>> > tfpt review "/shelveset:unni1;REDMOND\jdeville"<o:p></o:p></pre><pre>> > Comment :<o:p></o:p></pre><pre>> > Patch from Unnikrishnan Nair to properly handle File.zero? for<o:p></o:p></pre><pre>> 'NUL'<o:p></o:p></pre><pre>> ><o:p></o:p></pre><pre>><o:p> </o:p></pre><pre>> _______________________________________________<o:p></o:p></pre><pre>> Ironruby-core mailing list<o:p></o:p></pre><pre>> Ironruby-core@rubyforge.org<o:p></o:p></pre><pre>> http://rubyforge.org/mailman/listinfo/ironruby-core<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>_______________________________________________<o:p></o:p></pre><pre>Ironruby-core mailing list<o:p></o:p></pre><pre>Ironruby-core@rubyforge.org<o:p></o:p></pre><pre>http://rubyforge.org/mailman/listinfo/ironruby-core<o:p></o:p></pre></blockquote>
</td>
</tr>
</table>
</div>
<pre>_______________________________________________<o:p></o:p></pre><pre>Ironruby-core mailing list<o:p></o:p></pre><pre>Ironruby-core@rubyforge.org<o:p></o:p></pre><pre>http://rubyforge.org/mailman/listinfo/ironruby-core<o:p></o:p></pre></blockquote>
</td>
</tr>
</table>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Calibri","sans-serif"'><o:p> </o:p></span></p>
</div>
</div>
</body>
</html>