<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:D="DAV:" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:wf="http://schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:mver="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:mrels="http://schemas.openxmlformats.org/package/2006/relationships" xmlns:ex12t="http://schemas.microsoft.com/exchange/services/2006/types" xmlns:ex12m="http://schemas.microsoft.com/exchange/services/2006/messages" xmlns:Z="urn:schemas-microsoft-com:" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-GB link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><span style='color:#1F497D'>Hi Jim,<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Great stuff. The more I use Git
and GitHub the more I love it.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>I started to write comments, in
GitHub, against the commits but then thought better of it. I don’t
know what happens to them.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Sorry if some of these comments
are pedantic. Feel free to ignore them.<br>
Pete<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Commit 12308400<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- There is a typo in the
description of the it "yields while decreaing[sic] self until it less than
ceil for a Float endpoint" description<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- Should you also consider testing
downto and upto towards negative floats since Ruby has different semantics for
ceil than some other languages? E.g. 3.downto(-1.3) should produce [3,
2, 1, 0, -1] rather than [3,2,1,0,-1,-2].<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Commit fb9a920<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- Do you need to remove the
constant that is created inside it "should perform top level evaluations
from inside a block" to prevent leakage of memory and/or semantic?<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>Commit cc48d366<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- There is a typo in the
description of the it "includes the curret[sic] directory" description.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- My version of MRI Ruby does
not have a RUBY_ENGINE constant. If this is the case does the whole it
clause need to be wrapped in a compliant_on() block?<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'>- There is a typo in the description
of the it "allow substitutionof[sic] literal regexps" description.<o:p></o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>
<p class=MsoNormal><b><span lang=EN-US style='font-size:10.0pt;font-family:
"Tahoma","sans-serif"'>From:</span></b><span lang=EN-US style='font-size:10.0pt;
font-family:"Tahoma","sans-serif"'> ironruby-core-bounces@rubyforge.org
[mailto:ironruby-core-bounces@rubyforge.org] <b>On Behalf Of </b>Jim Deville<br>
<b>Sent:</b> Friday,11 July 11, 2008 07:17<br>
<b>To:</b> ironruby-core@rubyforge.org; IronRuby External Code Reviewers;
Srivatsn Narayanan<br>
<b>Subject:</b> [Ironruby-core] More spec review<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><span lang=EN-US>I’ve commited some more stuff to my
Rubyspec fork, I’d like to get some reviews before I merge them to Johns.
The commit numbers are:<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>123084<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>fb9a920<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>b7d69ef<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>ddbab38<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>a2a3c4b<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>cc48d366<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>That’s the last 6 commits I’ve
made.<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>Thanks.<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
<p class=MsoNormal><span lang=EN-US>~~~~<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>JD<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US>http://blog.jredville.com<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p>
</div>
</body>
</html>