[Ironruby-core] Code Review - Time#strftime ignore invalid directives on format string

Enrico Sada enrico.sada at gmail.com
Tue Aug 2 12:44:53 EDT 2011


i asked a pull request ( https://github.com/IronLanguages/main/pull/28
) for fix Time#strftime behaviour on invalid directives on format
string, ex:

ruby 1.8:
Time.now.strftime '%$' => '$'
ruby 1.9:
Time.now.strftime '%$' => '%$'

this make green a mspec test on core/time/strftime_spec.rb

I have some question:
1) i added a check for ruby compatibility >= ruby 1.9, is needed?
2) i removed 'fails:' from
ironruby-tags-19/core/time/strftime_tags.txt is correct?
3) usually code review is in mailing list or github pull request? (so
i dont need to write two times the same questions)


More information about the Ironruby-core mailing list