[Ironruby-core] FYI Code Review: config

Will Green will at hotgazpacho.org
Thu Mar 11 15:16:26 EST 2010


I still have misgivings about RUBY_PLATFORM identifying the underlying OS,
when in reality, the platform that Ruby is running on is the CLR.

Based on this change, I will update my patch for Ruby Gems and resubmit to
that team.

--
Will Green
http://hotgazpacho.org/


On Thu, Mar 11, 2010 at 2:53 PM, Jim Deville <jdeville at microsoft.com> wrote:

> Looks good. As part of MQ, we should look deeply at the compilation based
> variables and see if they can be removed or picked up from the arguments to
> csc.
>
> JD
>
>
> -----Original Message-----
> From: Shri Borde
> Sent: Thursday, March 11, 2010 11:36 AM
> To: IronRuby External Code Reviewers
> Cc: ironruby-core at rubyforge.org
> Subject: FYI Code Review: config
>
>  tfpt review "/shelveset:config;REDMOND\sborde"
>  Comment  :
>  Change RbConfig::CONFIG["arch"] to "universal-dotnet2.0" (or
> "universal-dotnet4.0" on .NET 4)
>  Also changed RbConfig::CONFIG["host_os"] to be based on RUBY_PLATFORM so
> that it will be mswin32 on Windows and linux on Linux.
>  Removed some config values that are not present in JRuby
>
>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100311/a6ed45c6/attachment.html>


More information about the Ironruby-core mailing list