[Ironruby-core] Code Review: gems

Jim Deville jdeville at microsoft.com
Tue Mar 9 13:46:42 EST 2010


Looks good. We should probably make the same change in the Excel specs, but that isn't pressing. 

-----Original Message-----
From: Shri Borde 
Sent: Tuesday, March 09, 2010 10:41 AM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: gems

  tfpt review "/shelveset:gems;REDMOND\sborde"

  Comment  : 
  When installing gems from a remote server that is using MRI, the gem information that is
   sent down to the local machine is incorrect since MRI is not able to parse the platform
   string of "universal-.net" until a patch is applied to RubyGems in Gem::Platform#initialize,
   similar to the way other platforms are handled in that method. IronRuby does include
   this patch. For now, we work around the problem in Gem::Specification._load

  Adds a case for "universal-.net" to Gem::Platform#=~. This may not be strictly needed to fix the problem above, but is included for completeness

  Running word_spec was leaving behind a Word dialog box asking whether to save the Word document or not. Fixed the spec to close Word without prompting.




More information about the Ironruby-core mailing list