[Ironruby-core] Code Review: dash_s
Jimmy.Schementi at microsoft.com
Mon Jan 25 01:31:48 EST 2010
> Could you factor the file search out into a private method?
> I noticed that -S should use the first file it finds on the path, can
> you do a spec for that?
... and done (though, isn't that the definition of the path? =P)
Attached diff, or
tfpt review "/shelveset:dash_upper_s;REDMOND\jimmysch"
> -----Original Message-----
> From: Jimmy Schementi
> Sent: Sunday, January 17, 2010 2:52 AM
> To: ironruby-core at rubyforge.org
> Cc: IronRuby External Code Reviewers
> Subject: Code Review: dash_s
> -S finds the file being run on the environment's PATH, rather than requiring
> the full path to be provided.
> Adds the -S command-line option (for example: ir -S irb)
> Add spec for -S
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 6363 bytes
More information about the Ironruby-core