[Ironruby-core] Code Review: rails

[Jim Deville]

ok



-----Original Message-----
From: Shri Borde <Shri.Borde at microsoft.com>
Sent: Friday, January 22, 2010 4:37 PM
To: Jim Deville <jdeville at microsoft.com>; IronRuby External Code Reviewers <irbrev at microsoft.com>
Cc: ironruby-core at rubyforge.org <ironruby-core at rubyforge.org>
Subject: RE: Code Review: rails


Let me run them overnight to catch non-determinstic failures, but they have been reasonably stable so far.

-----Original Message-----
From: Jim Deville
Sent: Friday, January 22, 2010 2:53 PM
To: Shri Borde; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: rails

Looks good, are the rails tests ready to go into SNAP?

JD

-----Original Message-----
From: Shri Borde
Sent: Friday, January 22, 2010 2:26 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: rails

  tfpt review "/shelveset:rails;REDMOND\sborde"
  Comment  :
  Flushes out iconv implementation. Added more specs
  Made String#encoding visible only in 1.9 mode
  Adds optional paramter to StringScanner.new
  The above fixes enable many more Rails tests