[Ironruby-core] Code Review: crit_argf

Tomas Matousek Tomas.Matousek at microsoft.com
Wed Jan 20 20:52:52 EST 2010

Could you add comments "TODO: thread safety" to the added fields. There are several places that access them in thread unsafe way.
Could you also replace
                    return MutableString.CreateAscii(CommandLineArguments[_currentFileIndex].ToString());
 	    // TODO: convert any non-string
                    return (MutableString)CommandLineArguments[_currentFileIndex];


-----Original Message-----
From: Jim Deville 
Sent: Wednesday, January 20, 2010 5:06 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: crit_argf

  tfpt review "/shelveset:crit_argf;REDMOND\jdeville"
  Comment  : 
  cleans up a few critical tags:
  * re-patches mock.rb with the patch to remove respond_to last
  * implements a basic implementation of ARGF, there are many holes that still need to be filled here, but the basic idea works, and the specs are no longer critical.

More information about the Ironruby-core mailing list