[Ironruby-core] Code Review: dash_s

Tomas Matousek Tomas.Matousek at microsoft.com
Tue Jan 19 14:19:05 EST 2010


Looks good. Could you factor the file search out into a private method?

Tomas

-----Original Message-----
From: Jimmy Schementi 
Sent: Sunday, January 17, 2010 2:52 AM
To: ironruby-core at rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: Code Review: dash_s

-S finds the file being run on the environment's PATH, rather than requiring the full path to be provided.

Adds the -S command-line option (for example: ir -S irb)
http://github.com/jschementi/ironruby/commit/135d5e5715409a194191c51c0566863603f49e16

Add spec for -S
http://github.com/jschementi/ironruby/commit/62f211de25d1e7c7793b4f9af36cfde3670247f8



More information about the Ironruby-core mailing list