[Ironruby-core] Code Review: More ActionPack fixes

Tomas Matousek Tomas.Matousek at microsoft.com
Tue Jan 19 14:16:03 EST 2010


Looks good.

Tomas

-----Original Message-----
From: Shri Borde 
Sent: Tuesday, January 19, 2010 12:44 AM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: More ActionPack fixes

  tfpt review "/shelveset:rails;REDMOND\sborde"
  Comment  : 
  defined? should clear $! of any exception that may have been thrown by const_missing
  Makes NativeMethods.SetEnvironmentVariable check if the call succeeded
  Adds a critical tag for library\socket\basicsocket\send_spec as it hung on my machine




More information about the Ironruby-core mailing list