[Ironruby-core] Review: ActionPack fix

Shri Borde Shri.Borde at microsoft.com
Wed Jan 13 12:41:52 EST 2010


The ActiveRecord tests in irtests.rb has never been really enabled for real (it was enabled with --all but no one used --all). The tests do work with a little bit of manual setup (downloading ironruby-dbi, creating the two required test databases, etc), but they should be enabled in irtests only when they are fully automated.

From: Jimmy Schementi
Sent: Tuesday, January 12, 2010 7:05 PM
To: Shri Borde; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Review: ActionPack fix

Is ActiveRecord supposed to be commented out (irtests.rb#46)? Also, we should upgrade to testing the latest version of Rails (2.3.5), but it doesn't have to be now.

Looks good otherwise,
~js

From: Shri Borde
Sent: Tuesday, January 12, 2010 4:14 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Review: ActionPack fix

tfpt review /shelveset:rails;sborde

Fixes a bug in Proc equality comparison which was causing the ActionPack caching tests to fail
Splits up the Rails test harness files into tests that fail with MRI as well (which are often issues with the test)
Changes the tests to load specific versions of Rails and other gems. Without that, you get load errors because of incorrect versions being loaded
Changed the default of irtests to run the Rails tests. They can be skipped by using -m (for "minimum")
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100113/78e363c5/attachment-0001.html>


More information about the Ironruby-core mailing list