[Ironruby-core] Code Review: Mono5

Tomas Matousek Tomas.Matousek at microsoft.com
Wed Jan 6 17:23:30 EST 2010


  tfpt review "/shelveset:Mono5;REDMOND\tomat"

Adds support for Mono to Dev.bat. Dev.bat takes an optional "mono" parameter and a path to the Mono bin directory. If supplied, it sets ROWAN_RUNTIME environment variable to "mono" and Mono bin directory is added to PATH. ROWAN_RUNTIME variable is used by ir.cmd, irtest, and irtests.rb.

Adds aliases ipym, ipyrm, ipydm, rbxm, rbrm, rbdm that launch IronPython and IronRuby on Mono.

Fixes issues reported by mcs.

Mono's msbuild implementation, xbuild, almost works for Ruby.sln and IronPython.sln. The only problem is with warnings-as-errors flag, which is handled incorrectly by xbuild (see http://bugzilla.novell.com/show_bug.cgi?id=566087). The bug has been fixed already but binaries that would include the fix are not available yet.

I've discovered and filed 10 bugs by running Ruby tests:

Open:
http://bugzilla.novell.com/show_bug.cgi?id=566241
http://bugzilla.novell.com/show_bug.cgi?id=566152
http://bugzilla.novell.com/show_bug.cgi?id=566117
http://bugzilla.novell.com/show_bug.cgi?id=565129
http://bugzilla.novell.com/show_bug.cgi?id=565152

Fixed in source, not shipped yet:
http://bugzilla.novell.com/show_bug.cgi?id=566106
http://bugzilla.novell.com/show_bug.cgi?id=565120
http://bugzilla.novell.com/show_bug.cgi?id=565143

Fixed and shipped in 2.6.1:
http://bugzilla.novell.com/show_bug.cgi?id=565117
http://bugzilla.novell.com/show_bug.cgi?id=565127

Tomas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Mono5.diff
Type: application/octet-stream
Size: 30793 bytes
Desc: Mono5.diff
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100106/8a454cc1/attachment-0001.obj>


More information about the Ironruby-core mailing list