[Ironruby-core] FW: Code Review: G19.Final

Tomas Matousek Tomas.Matousek at microsoft.com
Thu Aug 19 04:52:27 EDT 2010

They did.


I forgot to attach a git comment to this shelveset, so unfortunately it just says "Sync to TFS changeset #".


-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Daniele Alessandri
Sent: Thursday, August 19, 2010 1:02 AM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] FW: Code Review: G19.Final

I guess those changes have not made it to the git repository yet, right?
Anyway that's some great news, thanks again for all the awesome work!

On Tue, Aug 17, 2010 at 03:42, Tomas Matousek <Tomas.Matousek at microsoft.com> wrote:
> This change might break apps that already worked with IronRuby v1.0 or v1.1. The reason might be:
> - IronRuby is now using 1.9.1 standard libraries, which might depend on 1.9 features that are not yet implemented in IronRuby or are implemented incorrectly.
> or
> - the app uses 1.8 specific feature that is no longer supported in 1.9 (might be a grammar change or change in runtime behavior).
> If you need a stable IronRuby build that is compatible with 1.8.6 please use IronRuby v1.0 or v1.1 released in July. IronRuby v1.1 isn't as stable as v1.0 but is still compatible with 1.8.6.
> And as usual, contributions are welcome. Should you find a missing 1.9 feature don't hesitate, implement it and submit a patch!
> Tomas
> -----Original Message-----
> From: Tomas Matousek
> Sent: Monday, August 16, 2010 6:16 PM
> To: IronRuby External Code Reviewers
> Cc: ironruby-core at rubyforge.org
> Subject: Code Review: G19.Final
>  tfpt review "/shelveset:G19.Final;REDMOND\tomat"
>  Comment  :
>  Implements many 1.9 features and changes:
>  -     Syntax - should now be fully compatible with 1.9.2.
>  -     Semantics - many fixes, some features still not completed:
>          o     Passing optional and block parameters to blocks
>          o     Compound parameters unpacking, e.g. def foo((a, b), c); 
> end
>  -     Various small changes in libraries.
>  Removes version command line switches (-1.9, -1.8). The only supported MRI version is 1.9 from now on. I've kept RubyCompatibility enum for now, but it should be removed along with all 1.8 specific features.
>  Since we are still missing a lot of 1.9 features many failing tests and specs needs to be disabled for now (including Rails, Rubygems, and Rack).
> Tomas
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core

Daniele Alessandri
Ironruby-core mailing list
Ironruby-core at rubyforge.org

More information about the Ironruby-core mailing list