[Ironruby-core] Code Review: Fix for File.print misbehavior
Shri.Borde at microsoft.com
Sat May 16 02:30:00 EDT 2009
"writes each obj.to_s to the stream and appends $\\ (if any) given multiple objects" does not have a tag for it. If it did, it would be in Merlin\External.LCA_RESTRICTED\Languages\IronRuby\mspec\ironruby-tags\core\io\print_tags.txt, but that file only has a tag for "writes $_.to_s followed by $\ (if any) to the stream if no arguments given". I incorrectly thought that these were the same test name, but clearly they are not.
It's a mystery how "writes each obj.to_s to the stream and appends $\\ (if any) given multiple objects" works, but your example below fails. Could you could step into IoOps.Print for this test without your fix and see how it works? Else, I can try it next week.
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Shay Friedman
Sent: Friday, May 15, 2009 10:51 PM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] Code Review: Fix for File.print misbehavior
Regarding the contributor agreement - yes, I've signed that (Jim Deville
helped me with that).
Regarding the coding conventions - I didn't notice the "modifying the
sources" page, sorrry for that... I would pay attention to that next
About RubySpec - "writes each obj.to_s to the stream and
appends $\\ (if any) given multiple objects" really seems like the
corresponding test to my fix. What are the tags for?
The test mentioned on print_tags.txt should also pass after this commit.
About irtests - I ran it. I saw the 5 failures from run.bat but I
couldn't find the place where the RubySpec specs failures were
presented. What am I doing wrong?
Posted via http://www.ruby-forum.com/.
Ironruby-core mailing list
Ironruby-core at rubyforge.org
More information about the Ironruby-core