[Ironruby-core] expand_path & Rspec

Tomas Matousek Tomas.Matousek at microsoft.com
Fri Mar 27 15:56:15 EDT 2009


There will be issues with expand_path as long as it uses Path.GetFullPath and Path.Combine. These methods check for invalid path characters while expand_path doesn't. So we need an implementation that doesn't use Path.* methods.

Tomas

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Shri Borde
Sent: Friday, March 27, 2009 12:40 PM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] expand_path & Rspec

I fixed this particular issue. See attached. Its not in the main GIT repo though. 

The workaround for running the rubyspecs is to set HOME manually to %USERPROFILE%. We are also fixing dev.bat to set HOME for you, so you won't have to worry about it.

There are plenty of other tags (which disables a failing test) in http://github.com/ironruby/ironruby/tree/17de3f8220b0aa9da96f9c8f0c132db954721375/Merlin/External/Languages/IronRuby/mspec/ironruby-tags/core/file. Delete anyone of them, run "mspec ci core\file" to see the test start failing (since the tag is gone), and then work on a fix. Once you have drilled into the issue a bit, I can help you as mentioned in the attached email.

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Michael Delaney
Sent: Friday, March 27, 2009 11:42 AM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] expand_path & Rspec

so its a bug then.
ok, i'll take a look at it.
any tips for a first time contributor ;-)
-- 
Posted via http://www.ruby-forum.com/.
_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core



More information about the Ironruby-core mailing list