[Ironruby-core] Code Review: RuntimeBoundRules

Tomas Matousek Tomas.Matousek at microsoft.com
Wed Mar 25 23:50:01 EDT 2009


  tfpt review "/shelveset:RuntimeBoundRules;REDMOND\tomat"
  Comment  : 
  Implements atomizer for Ruby call site binders: A new class RubyMetaBinderFactory creates sites and caches them in dictionaries.
  Sites are either bound to a runtime (RubyContext) or not. Bound sites don't emit context check, unbound need to. Bound sites don't take RubyContext as the first parameter any more. They can still take RubyScope if needed (such sites have HasScope flag set). Replaces SiteLocalStorage with RubyCallSiteStorage that holds on the context so that it is not necessary to pass RubyContext to the sites stored in the storage. Updates all sites in libraries accordingly.
  
  Adds -ER command line option that enables tracing of meta-objects (rules) created by Ruby.
  Refactors MetaObjectBuilder to use type restrictions rather than expression restrictions.
  Removes RubyClassAttribute.MixinInterfaces - it didn't work correctly and was almost unused.
  
  Also improves handling of BOM in 1.8 mode - we previously did exactly what Ruby does, i.e. report a syntax error from which it is not obvious what's wrong. If -KU is not specified and UTF8 BOM is found at the beginning of the source code, the tokenizer reports a level 2 warning, skips the BOM as if it was whitespace and continues reading the file.
  

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: RuntimeBoundRules.diff
Type: application/octet-stream
Size: 797016 bytes
Desc: RuntimeBoundRules.diff
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090325/f88267b4/attachment-0001.obj>


More information about the Ironruby-core mailing list