[Ironruby-core] Code Review: DMO1

Tomas Matousek Tomas.Matousek at microsoft.com
Tue Mar 17 13:26:45 EDT 2009


Good catch. Will fix it in the next changeset.

Tomas

-----Original Message-----
From: Curt Hagenlocher 
Sent: Tuesday, March 17, 2009 9:14 AM
To: Tomas Matousek; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: DMO1

In RubyClass.cs, there's an incorrect parameter passed to SetWrongNumber:

var actualArgs = RubyMethodGroupBase.NormalizeArguments(metaBuilder, args, SelfCallConvention.NoSelf, false, false);
if (actualArgs.Length == 1) {
    ...
} else {
    metaBuilder.SetWrongNumberOfArgumentsError(actualArgs.Length, 0); <-- should be "1".
}

Looks good otherwise.

-----Original Message-----
From: Tomas Matousek 
Sent: Monday, March 16, 2009 6:38 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: DMO1

  tfpt review "/shelveset:DMO1;REDMOND\tomat"
  Comment  : 
  -	Checks for an invalid number of arguments is passed to an attribute setter/getter or struct field setter/getter. 
  -	Implements correct splatting of arguments to Delegate constructor and enables previously failing tests.
  -	Refactors RubyMethodGroupBase in preparation for obsolete API usage removal.
  -	Fixes a comment and adds OBSOLETE comments to obsolete API of MethodBinder and BindingTarget classes.

Tomas


More information about the Ironruby-core mailing list