[Ironruby-core] Code review: String#unpack, Bignum and Array related stuff

Daniele Alessandri suppakilla at gmail.com
Wed Jul 22 16:51:12 EDT 2009

Just a quick note: updated with

On Sun, Jul 19, 2009 at 11:29, Daniele Alessandri<suppakilla at gmail.com> wrote:
> Hi
> first of all I am trying a different approach to submitting my
> patches: I created a code_review branch on my repository in which I am
> going to push all my fixes for review. Fixes that will pass review
> will be rebased (not merged) in my main branch (ready to get pulled
> into the ironruby repository), the others will remain staged in my
> code_review branch for further works until they are "approved". I am
> just experimenting a different git workflow :-)
> Anyway, let's move on to the new commits:
> * http://github.com/nrk/ironruby/commit/48a4a02b5b47d61f2f7a3f3887ea4bf02d63edb4
> - More fixes for String#unpack:
>   o Fixed errors when unpacking data with 'Z' and '@' directives
>   o Implemented 'Q' and 'q' directives
> * http://github.com/nrk/ironruby/commit/17b5edab64967b0200370edf6657321a0f79953d
> - Array related fixes:
>   o Array#== does not call #to_ary on its argument but it calls #to_a (it
>   basically performs a conversion of the argument rather than casting it to a
>   ruby array)
>   o Array#zip calls #to_ary to cast the argument to an Array, therefore it
>   overrides Enumerable#zip in which the argument is converted by calling
>   #to_a.
> * http://github.com/nrk/ironruby/commit/547d810c78b38afc34e728855ab7d0c20f499719
> - Bignum related fixes:
>   o Changed the signature for ClrBigInteger.ToString(self,radix), now
>   Bignum#to_s works as expected raising an ArgumentException if base is less
>   than 2 or higher than 36.
>   o Fixed Bignum#divmod, Bignum#remainder, Bignum#% and Bignum#modulo to work
>   with Float values as argument.
>   o Fixed Bignum#/ and Bignum#div as they behave differently with each other
>   when Float values are passed as argument.
> Note: Now bignum does not fail any of the expectations in core/bignum.
> See also the attached diff.
> Thanks,
> Daniele

Daniele Alessandri

More information about the Ironruby-core mailing list