[Ironruby-core] Review: misc fixes to MutableStringOps.cs

Tomas Matousek Tomas.Matousek at microsoft.com
Thu Jul 16 18:02:25 EDT 2009


MutableString already has RequireNotFrozen method. You don't need to add it to MutableStringOps.

There already is a check in Translate and TrSequezeInPlace: self.RequireNotFrozen(); 

Tomas

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Shri Borde
Sent: Thursday, July 16, 2009 2:42 PM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] Review: misc fixes to MutableStringOps.cs

I see. OK then.

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Daniele Alessandri
Sent: Thursday, July 16, 2009 2:39 PM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] Review: misc fixes to MutableStringOps.cs

On Thu, Jul 16, 2009 at 23:25, Shri Borde<Shri.Borde at microsoft.com> wrote:

> Could you update BlockReplaceInPlace in MutableStrinOps.cs to also use RequiresNotFrozenString?

BlockReplaceInPlace seems correct as is to me, String#gsub! raises a RuntimeError instead of a TypeError when self is frozen.

--
Daniele Alessandri
http://www.clorophilla.net/blog/
http://twitter.com/JoL1hAHN
_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core

_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core



More information about the Ironruby-core mailing list