[Ironruby-core] Code Review: GenericMethodsAndOverloads

Curt Hagenlocher curth at microsoft.com
Tue Jan 13 19:34:10 EST 2009


Changes look good overall.

In RubyMethodGroupInfo.TryBindGenericParameters, an empty set of types will return all methods in MethodBases whether or not they're generic.  What's the reason for this behavior?

There's a chunk of code that was added to Utils.cs that's indented too far.

-----Original Message-----
From: Tomas Matousek 
Sent: Monday, January 12, 2009 2:34 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: GenericMethodsAndOverloads

  tfpt review "/shelveset:GenericMethodsAndOverloads;REDMOND\tomat"

    Implements generic methods parameters binding and explicit overload selection. Adds methods Method/UnboundMethod#of and Method/UnboundMethod#overloads. Method#of takes a list of Ruby classes or CLR types and returns a Method instance that has bound generic parameters to these classes/types. Method#overloads takes a list of Ruby classes or CLR types and returns a Method instance that includes only those CLR methods grouped in the Method object whose parameters are of the given types.

Tomas


More information about the Ironruby-core mailing list