[Ironruby-core] Code Review: hangs in core\thread

Shri Borde Shri.Borde at microsoft.com
Wed Jan 7 17:17:39 EST 2009


Since no one has reviewed this yet, I have updated the change to factor out the tests for alive?, inspect, status and stop?

Another product change was that Thread#value should return false if the thread was killed. Only a thread with an uncaught exception should return nil.

Thanks,
Shri

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Shri Borde
Sent: Tuesday, January 06, 2009 11:49 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: [Ironruby-core] Code Review: hangs in core\thread

  tfpt review "/shelveset:hangs;REDMOND\sborde"

  Comment  : 
  Non-deterministic fixes. I ran all the core\thread specs in a loop in multiple processes and ran into a few non-deterministic failures. This change fixes everything I ran into. The only product change is that Thread#wakeup is not queued up if the target thread is not sleeping. This is the MRI behavior.

 Also started using comments in the tag files like this - fails("reason why"):test name. I will undo this if Jim says that he will be regenerating the tags file periodically.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: hangs.diff
Type: application/octet-stream
Size: 26816 bytes
Desc: hangs.diff
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090107/19b136cd/attachment-0001.obj>


More information about the Ironruby-core mailing list