[Ironruby-core] Code Review: rakecrossplatform

Jim Deville jdeville at microsoft.com
Fri Jan 2 15:07:53 EST 2009


Committing with Michael's suggestion.

JD

From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Michael Letterle
Sent: Wednesday, December 31, 2008 8:23 PM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] Code Review: rakecrossplatform

By the by, forward slashes are acceptable as path separators in windows as well as under unix.  This /may/ be more acceptable as it's clearer, IMHO.
On Wed, Dec 31, 2008 at 4:29 PM, Jim Deville <jdeville at microsoft.com<mailto:jdeville at microsoft.com>> wrote:
I'm going to directly commit this since it doesn't affect tests.

JD

-----Original Message-----
From: Curt Hagenlocher
Sent: Wednesday, December 31, 2008 1:17 PM
To: Jim Deville; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org<mailto:ironruby-core at rubyforge.org>
Subject: RE: Code Review: rakecrossplatform

Looks good!

-----Original Message-----
From: Jim Deville
Sent: Wednesday, December 31, 2008 12:21 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org<mailto:ironruby-core at rubyforge.org>
Subject: Code Review: rakecrossplatform

 tfpt review "/shelveset:rakecrossplatform;REDMOND\jdeville"
 Comment  :
 Fixes the imports to reference the files in a platform agnostic way.


_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org<mailto:Ironruby-core at rubyforge.org>
http://rubyforge.org/mailman/listinfo/ironruby-core



--
Michael Letterle
[Polymath Prokrammer]
http://blog.prokrams.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090102/e4a10e98/attachment-0001.html>


More information about the Ironruby-core mailing list