[Ironruby-core] Code Review: netinterop1
Jimmy.Schementi at microsoft.com
Wed Feb 25 19:57:58 EST 2009
Do people prefer using "\" or "/" as the directory separator in Ruby code? I prefer "/" since all existing Ruby code uses that, and Ruby on windows understands it as well. Plus you don't have to play the escape-slash game when using double-quoted strings.
Also, some folks might be confused at the strange class/method names uses in these tests. They come from rowantest.*.dll, which are full of test cases IronPython uses for .NET interop testing, so we are just reusing them. However, it's only a temporary solution, as we'll probably move to a C#-code-inline approach which Jim is going to get working shortly.
Regardless, I approve =)
> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Jim Deville
> Sent: Wednesday, February 25, 2009 3:01 PM
> To: IronRuby External Code Reviewers
> Cc: ironruby-core at rubyforge.org
> Subject: [Ironruby-core] Code Review: netinterop1
> tfpt review "/shelveset:netinterop1;REDMOND\jdeville"
> Comment :
> Adds more netinterop tests related to methods.
> Adds these tests to snap.
> Reorganizes the ruby generictest folder
> Adds the command line tests to snap
> Adds tags for netinterop
> Modifies testsupport.cs (ClrAssembly) to make the Flag Value field
> public to match with other Flag classes, and to work better with Ruby
More information about the Ironruby-core