[Ironruby-core] Code Review: esupport

Tomas Matousek Tomas.Matousek at microsoft.com
Wed Feb 18 21:44:34 EST 2009


Looks good.

Tomas

-----Original Message-----
From: Jim Deville 
Sent: Wednesday, February 18, 2009 6:10 PM
To: Jim Deville; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: esupport

Updated shelveset to add tests, and make __FILE__ work correctly.

  tfpt review "/shelveset:esupport;REDMOND\jdeville"
  Comment  : 
  Adds -e support to IronRuby using CommonConsoleOptions.Command. Adds basic tests for -e. Finally, it makes the parser set __FILE__ to -e when it parses a SourceUnit from -e. Also fixes a formatting error in ConsoleHost.cs



-----Original Message-----
From: Jim Deville 
Sent: Wednesday, February 18, 2009 5:03 PM
To: IronRuby External Code Reviewers; DLR Code Reviews
Cc: ironruby-core at rubyforge.org
Subject: Code Review: esupport

DLR: FYI on formatting change. No response needed.

  tfpt review "/shelveset:esupport;REDMOND\jdeville"
  Comment  : 
  Adds -e support to IronRuby using CommonConsoleOptions.Command. Also fixes a formatting error in ConsoleHost.cs




More information about the Ironruby-core mailing list