[Ironruby-core] Code Review: core/module/autoload

Tomas Matousek Tomas.Matousek at microsoft.com
Wed Apr 22 13:46:54 EDT 2009


Looks good.

Tomas

-----Original Message-----
From: Jimmy Schementi 
Sent: Wednesday, April 22, 2009 10:45 AM
To: Tomas Matousek; ironruby-core at rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: RE: Code Review: core/module/autoload

http://github.com/jschementi/ironruby/commit/78bd7541cebae33b3b07bfed17ce74a63ecb49d4

Code review updates:
- Don't combine paths with '/' if the base-path already ends with '/' or '\\'

    * Merlin/Main/Languages/Ruby/Ruby/Runtime/Loader.cs
    * Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyUtils.cs

> -----Original Message-----
> From: Tomas Matousek
> Sent: Tuesday, April 21, 2009 8:33 AM
> To: ironruby-core at rubyforge.org
> Cc: IronRuby External Code Reviewers
> Subject: RE: Code Review: core/module/autoload
> 
> / is not appended if the path ends with /. It is if it ends with \ -
> which seems like a bug in Ruby that we shouldn't copy.
> Could you rather implement " Combine" somewhere (in RubyUtils e.g.)
> that uses / for joining paths but checks if the directory ends with \
> or /?
> 
> Tomas
> 
> 
> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Jimmy Schementi
> Sent: Monday, April 20, 2009 11:52 PM
> To: ironruby-core at rubyforge.org
> Cc: IronRuby External Code Reviewers
> Subject: [Ironruby-core] Code Review: core/module/autoload
> 
> http://github.com/jschementi/ironruby/commit/bbfa3c4a35cc331e58fb9da9a4
> 097de86ed0dbff
> 
> autoload uses '/' to join load-path and autoload-path.
> Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=674
> 
> This makes Rails 2.3.2 startup without any modifications! =)
> 
> Changes:
> -
> Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/m
> odule/autoload_spec.rb
> -
> Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/m
> odule/fixtures/autoload_join.rb
> - Merlin/Main/Languages/Ruby/Ruby/Runtime/Loader.cs
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core



More information about the Ironruby-core mailing list