[Ironruby-core] Code Review: core/module/autoload

Tomas Matousek Tomas.Matousek at microsoft.com
Tue Apr 21 11:33:15 EDT 2009


/ is not appended if the path ends with /. It is if it ends with \ - which seems like a bug in Ruby that we shouldn't copy.
Could you rather implement " Combine" somewhere (in RubyUtils e.g.) that uses / for joining paths but checks if the directory ends with \ or /?

Tomas


-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Jimmy Schementi
Sent: Monday, April 20, 2009 11:52 PM
To: ironruby-core at rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: [Ironruby-core] Code Review: core/module/autoload

http://github.com/jschementi/ironruby/commit/bbfa3c4a35cc331e58fb9da9a4097de86ed0dbff

autoload uses '/' to join load-path and autoload-path.
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=674

This makes Rails 2.3.2 startup without any modifications! =)

Changes:
- Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/autoload_spec.rb
- Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/fixtures/autoload_join.rb
- Merlin/Main/Languages/Ruby/Ruby/Runtime/Loader.cs
_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core



More information about the Ironruby-core mailing list