[Ironruby-core] Review: String#% and File.rename

Jim Deville jdeville at microsoft.com
Thu Apr 9 16:17:00 EDT 2009


I would suggest using FileUtils.rm_rf instead of remove_dir at http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#L1R13

You also don't need to require fileutils as it is required as part of MSpec.

JD


From: Shri Borde
Sent: Thursday, April 09, 2009 12:06 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Review: String#% and File.rename

http://github.com/Jirapong/ironruby/commit/1eb5b389d849c5464f8d89090c7476a96f05c21e (Jirapong's fix)
http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f (my fixes)
http://github.com/shri/ironruby/commit/e8f840f5c800fa62f4987b8904569491ae9a8ba0  (merge with irmain HEAD)

GitDiff.bat fb6f89146e331a9f20f444d5ca94478dfce7f555 2cb2802a316c48721875204aa83cf5d0fa85cf3f


*         Jirapong's fix for File.new when file already exists

*         Fixed another bug in String#%

*         Bugs in File.rename

*         Ruby should exit when main thread exits, even if other threads are still alive

*         Mapped Errno::ENOENT to FleNotFoundException, and ENOTDIR to DirectoryNotFoundException

Files changed:

  *   Merlin/External/Languages/IronRuby/mspec/ironruby-tags/core/string/modulo_tags.txt<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-0>
  *   Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/rename_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-1>
  *   Merlin/External/Languages/IronRuby/mspec/rubyspec/core/string/modulo_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-2>
  *   Merlin/External/Languages/IronRuby/mspec/rubyspec/core/thread/new_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-3>
  *   Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Dir.cs<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-4>
  *   Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Errno.cs<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-5>
  *   Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-6>
  *   Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/IoOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-7>
  *   Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-8>
  *   Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/StringFormatter.cs<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-9>
  *   Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ThreadOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-10>
  *   Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-11>
  *   Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-12>
  *   Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_specs.rb
  *   Merlin/Users/sborde/Dev.bat<http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#diff-14>
Thanks,
Shri

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090409/4211764c/attachment-0001.html>


More information about the Ironruby-core mailing list