[Ironruby-core] Code Review: RandomRubyFixes01

Tomas Matousek Tomas.Matousek at microsoft.com
Sun Sep 21 18:33:52 EDT 2008


Right, our convention is not to copy documentation from ri.
I agree on access modifiers.

Tomas

-----Original Message-----
From: Oleg Tkachenko
Sent: Sunday, September 21, 2008 3:26 PM
To: Curt Hagenlocher; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: RandomRubyFixes01

I wonder why you removed spec comments from TimeOps? Not that I object that, just curious if our convention is not to include such things into the code.
Also you marked some methods in Marshal as private, while a bunch of them still left with no access modifier, I think we should be more consistent here and mark everything with explicit access modifiers.

Otherwise looks great.
--
Oleg


-----Original Message-----
From: Curt Hagenlocher
Sent: Saturday, September 20, 2008 7:11 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: RandomRubyFixes01

tfpt review "/shelveset:RandomRubyFixes01;REDMOND\curth"

Comment  :
  Fix many bugs in Marshal; now passes all but 5 tests
  Implement Time._load and Time._dump to support marshaling of Time objects
  Implement "arity" function for method groups
  Correctly scope the constant when looking for the YAML module in yaml_as

--
Curt Hagenlocher
curth at microsoft.com


More information about the Ironruby-core mailing list