[Ironruby-core] Code Review: remove_old_spec

Srivatsn Narayanan srivatsn at microsoft.com
Mon Sep 15 14:43:25 EDT 2008


Actually it should have a change - the entry for rubyspec.generictest should get deleted from the vbproj file. I don't know why its not there - did you perhaps not save the vbproj when you closed vs?

-----Original Message-----
From: Jim Deville
Sent: Monday, September 15, 2008 11:41 AM
To: Srivatsn Narayanan; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: remove_old_spec

Any idea why VS decided to check that file out?

I'm trying to get into the habit of running tfpt uu before shelving, but I missed it this time. I'll run that and the sortvsmdi script and resubmit.


JD

> -----Original Message-----
> From: Srivatsn Narayanan
> Sent: Monday, September 15, 2008 11:38 AM
> To: Jim Deville; IronRuby External Code Reviewers
> Cc: ironruby-core at rubyforge.org
> Subject: RE: Code Review: remove_old_spec
>
> Rowantest.vbproj doesn't have any changes. Could you sort the vsmdi
> (using sortvsmdi.py in test\scripts)? There are too many changes
> otherwise.
>
> -----Original Message-----
> From: Jim Deville
> Sent: Monday, September 15, 2008 11:29 AM
> To: IronRuby External Code Reviewers; Srivatsn Narayanan
> Cc: ironruby-core at rubyforge.org
> Subject: Code Review: remove_old_spec
>
> tfpt review "/shelveset:remove_old_spec;REDMOND\jdeville"
> Comment  :
>   This change removes the old specs from the test directory. It also
> removes the Rake tasks for those tests, and gets them out of SNAP.
>



More information about the Ironruby-core mailing list