[Ironruby-core] Code Review: RandomRubyFixes05

Tomas Matousek Tomas.Matousek at microsoft.com
Fri Oct 24 13:18:55 EDT 2008

Looks good.

There is a minor formatting glitch in RubyUtils:

            return new RubyCompilerOptions(targetScope.ExecutionContext.Context.RubyOptions)

(the opening brace on a new line). I guess you need to set this in VS formatting options.


-----Original Message-----
From: Curt Hagenlocher
Sent: Friday, October 24, 2008 8:23 AM
To: IronRuby External Code Reviewers; Oleg Tkachenko
Cc: ironruby-core at rubyforge.org
Subject: Code Review: RandomRubyFixes05

tfpt review "/shelveset:RandomRubyFixes05;REDMOND\curth"

Comment  :
  Factored class IOWrapper.cs out of Marshal and into the Ruby core so it can be accessed from multiple places
  Factored object creation out of Marshal and into RubyUtils so it can share code with Yaml
  Disabled name-mangling for symbol "initialize" so that CLR methods with the name Initialize don't cause trouble
  Implemented String.hex and String.oct
  Modified Socket and StringIO classes so they open in binary mode by default
  Extensive modifications to zlib:
    Fixed uncompressed blocks to inflate properly
    Reformatted to match standard
    Many small changes to cleanup code and improve performance
    Added support for reading from any object implementing "read" -- not just IO objects -- by using IOWrapper
  Added an overload to IO.seek that accepts BigInteger.  (This turned out not to be needed, but the code works.)
  Modified Yaml construction to call yaml_initialize if it exists

Curt Hagenlocher
curth at microsoft.com

More information about the Ironruby-core mailing list