[Ironruby-core] Code Review: ParseTree5

Tomas Matousek Tomas.Matousek at microsoft.com
Mon Oct 20 23:03:24 EDT 2008


tfpt review "/shelveset:ParseTree5;REDMOND\tomat"
Comment  :
  Bunch of tweaks to AST:
  - removes some nodes that are notneeded any more,
  - moves block argument out of Arguments to CallExpression,

  Fixes several bugs:
  - order of evaluation in "(x,y) while z",
  - passing parameters to a super method when a block is specified "super {}",
  - yield should report an error when a block argument is given "yield &p"

  Implements ParseTree library
  - there are few nodes that are to be finished,
  - in some cases the generated parse tree deosn't exactly match MRI (some of which I consider bugs in MRI),
  - adds ir_parse_tree.rb that implements the same API as parse_tree.rb calling to IronRuby for tree transformation,
  - only string parsing is supported now, getting AST from method/class at runtime is not yet implemented.

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ParseTree5.diff
Type: application/octet-stream
Size: 465969 bytes
Desc: ParseTree5.diff
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081020/82d3d7c6/attachment-0001.obj>


More information about the Ironruby-core mailing list