[Ironruby-core] Code Review (External): NumericalFixes

Peter Bacon Darwin bacondarwin at googlemail.com
Thu Oct 9 10:21:25 EDT 2008


Thanks Jim.  I pulled the latest rubyspecs and there are no unexpected
failures.

 

Still waiting for someone to review my code...

 

Pete

 

From: ironruby-core-bounces at rubyforge.org
[mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Jim Deville
Sent: Wednesday,08 October 08, 2008 21:44
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] Code Review (External): NumericalFixes

 

If you are running against the RubySpec's version of RubySpecs (as opposed
to the IronRuby repo) you may want to sync and test again. I pushed some
changes last night that make some of the float comparison do numerical
comparisons instead of string comparisons.

 

 

JD

 

From: ironruby-core-bounces at rubyforge.org
[mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Peter Bacon Darwin
Sent: Wednesday, October 08, 2008 10:09 AM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] Code Review (External): NumericalFixes

 

Ping!

 

From: Peter Bacon Darwin [mailto:bacondarwin at googlemail.com] 
Sent: Tuesday,07 October 07, 2008 14:38
To: 'ironruby-core at rubyforge.org'
Subject: Code Review (External): NumericalFixes 

 

A number of fixes to pass most of the relevant rubyspecs.

                BignumOps.cs: Leftshift and Rightshift fixes

                FixnumOps.cs: Leftshift, Rightshift, Bitwise_Xor,
Bitwise_And and Bitwise_Or fixes

                FloatOps.cs: Constant and IsNegativeZero modification.  Also
partial fix to ToS

                Integer.cs: DownTo and UpTo fixes

                Numeric.cs: Remainder and Step fixes.

 

(There are now only 2 failures in Numeric, 1 in Float and a number in
Bignum.)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081009/dd66617d/attachment-0001.html>


More information about the Ironruby-core mailing list