[Ironruby-core] Code Review: MoreDefaultProtocols

Curt Hagenlocher curth at microsoft.com
Mon Oct 6 19:42:44 EDT 2008


Ah, okay.  I obviously missed that they weren't RubyMethods.

-----Original Message-----
From: Tomas Matousek
Sent: Monday, October 06, 2008 4:38 PM
To: Curt Hagenlocher; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: MoreDefaultProtocols

The methods that take MutableString[] are not [RubyMethods] - they're just helper methods.
We don't support [DefaultProtocol] on arrays of MutableString yet. But this change is the first step in that direction.

UpdateTimes have two overloads - one taking a single string and the other arbitrary number of arbitrary objects on which default protocol conversion is applied. So as soon as [DefaultProtocol] works on params array we can use it here.

Tomas

-----Original Message-----
From: Curt Hagenlocher
Sent: Monday, October 06, 2008 4:34 PM
To: Tomas Matousek; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: MoreDefaultProtocols

Some methods that were changed from object[] to MutableString[] aren't tagged with [DefaultProtocol].  Is this conversion enabled by default?

Why can't FileOps.UpdateTimes use the protocol conversion? Is to for semantic compatibility? (ie don't call to_s if the time conversion fails)

Looks good otherwise.

-----Original Message-----
From: Tomas Matousek
Sent: Monday, October 06, 2008 3:37 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: MoreDefaultProtocols

tfpt review "/shelveset:MoreDefaultProtocols;REDMOND\tomat"

  Introduces more default protocol conversions.

Tomas


More information about the Ironruby-core mailing list