[Ironruby-core] Code Review: NoSymbolId1

Curt Hagenlocher curth at microsoft.com
Fri Oct 3 20:11:44 EDT 2008

Changes look good, overall.  I like the approach.

In Tokenizer.cs, you replaced Symbols.Minus with the hardcoded "-" -- but Symbols.Minus has separately been redefined to "-".  Best to continue to use the symbolic name, no?

-----Original Message-----
From: Tomas Matousek
Sent: Friday, October 03, 2008 3:08 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: NoSymbolId1

tfpt review "/shelveset:NoSymbolId1;REDMOND\tomat"

  Removes SymbolIds from IronRuby compiler and runtime. Still keeps SymbolId as a representation of Symbol Ruby class. The plan is to replace SymbolId completely by System.String with interning table on RubyContext (the integer values will be unique per script runtime). The table will hold on additional information about the strings (encoding, taint, instance variables, etc.).


More information about the Ironruby-core mailing list