[Ironruby-core] Code Review: bigdecimal-2

Tomas Matousek Tomas.Matousek at microsoft.com
Fri Oct 3 19:32:52 EDT 2008


I noticed the file name casing is wrong: bigdecimal.cs, fraction.cs. Was it broken by some transformation?

Tomas

-----Original Message-----
From: Curt Hagenlocher
Sent: Friday, October 03, 2008 4:03 PM
To: John Lam (IRONRUBY); IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: bigdecimal-2

Code looks good.  There might have been less churn to have CodeContext on each method now so that we can use it to get a Config later -- but there's also something to be said for making it work first.

Style consistency issues:
The line endings in bigdecimal.cs appear to be a mix of LF and CRLF.  They should all be CRLF.
We tend to prefer not to say "this.varname = x"; if the symbol name conflicts, it should be changed if possible.


-----Original Message-----
From: John Lam (IRONRUBY)
Sent: Friday, October 03, 2008 3:24 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: bigdecimal-2

tfpt review "/shelveset:bigdecimal-2;REDMOND\jflam"
Comment  :
  BigDecimal contribution from Peter Bacon Darwin




More information about the Ironruby-core mailing list