[Ironruby-core] Code Review: RandomRubyFixes03

Tomas Matousek Tomas.Matousek at microsoft.com
Thu Oct 2 18:30:47 EDT 2008


Missing overflow check in ThreadOps.cs:259

if (!self.Join((int)(timeout * 1000))) {

Other than that looks good.

Tomas


-----Original Message-----
From: Curt Hagenlocher
Sent: Thursday, October 02, 2008 3:26 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: RandomRubyFixes03

tfpt review "/shelveset:RandomRubyFixes03;REDMOND\curth"

Comment  :
  Implement unpack directive L as equivalent to I on this platform
  Fix stack overflow resulting from inspecting recursive objects
  Fix instance variable operations to use consistent context/scope variable type
  Implement Proc.binding
  Implement Thread.abort_on_exception, Thread.value.  Flow exceptions across Thread.join.  (ThreadOps is now in need of some refactoring...)
  Supply stack trace when there's no handler

--
Curt Hagenlocher
curth at microsoft.com


More information about the Ironruby-core mailing list