[Ironruby-core] Code Review: BacktraceFix

Tomas Matousek Tomas.Matousek at microsoft.com
Wed Oct 1 13:20:44 EDT 2008

One of the overload is called in CreateBacktrace and ref skipFrames is used there.
You're right about the other overload. I used the same pattern for consistency.


-----Original Message-----
From: Curt Hagenlocher
Sent: Wednesday, October 01, 2008 7:55 AM
To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers
Subject: RE: Code Review: BacktraceFix

Both overloads of RubyExceptionData.AddBacktrace take skipFrames as a reference parameter, but it doesn't look like any of the call sites care about the modified value.  Looks good otherwise.

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Tomas Matousek
Sent: Tuesday, September 30, 2008 5:27 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: [Ironruby-core] Code Review: BacktraceFix

tfpt review "/shelveset:BacktraceFix;REDMOND\tomat"
Comment  :
  Backtraces weren't handled correctly for rethrown exceptions.
  Adds some tests for backtraces and modifies the infrastructure to run unit tests in all combinations of /interpret and /partial modes.


More information about the Ironruby-core mailing list