[Ironruby-core] Code Review: RubyClrInterop05

Tomas Matousek Tomas.Matousek at microsoft.com
Fri Nov 21 14:10:01 EST 2008

Ruby changes look good.


-----Original Message-----
From: Curt Hagenlocher
Sent: Friday, November 21, 2008 1:33 AM
To: IronRuby External Code Reviewers; DLR Code Reviews
Cc: ironruby-core at rubyforge.org
Subject: Code Review: RubyClrInterop05

  tfpt review "/shelveset:RubyClrInterop05;REDMOND\curth"

  Comment  :
  A smörgåsbord of GetMemberNames
  Changes to Python, DLR outer ring:
      Removed OldGetMemberNames from API and moved legacy Python functionality into language context
      Fixed/added some comments
  Changes to Ruby:
      Use the RubyContext associated with the RubyClass for virtual method implementation instead of the default context
      Implement ICustomTypeDescriptor on RubyObject, typegen'd classes
      Moved ForEachMember functionality onto RubyModule where it can be used by CustomTypeDesc, MO
      Implemented GetDynamicMemberNames on RubyObject, RubyClass MOs
      Note to self: in the future, we could create a generic custom type descriptor on top of a MO

Curt Hagenlocher
curth at microsoft.com

More information about the Ironruby-core mailing list