[Ironruby-core] Code Review: VisibilityAndOtherFixes2

Curt Hagenlocher curth at microsoft.com
Mon Nov 17 13:38:26 EST 2008

Changes look good.

-----Original Message-----
From: Tomas Matousek
Sent: Sunday, November 16, 2008 1:11 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: VisibilityAndOtherFixes2

  tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
  Comment  :
      - private method visibility
      - DATA constant
      - popen and duplex IO streams (will need some refactoring of RubyIO object)

      - warnings (verbosity levels, Kernel#warn)
      - Kernel#gets, print, puts (no dynamic call to IO#puts)
      - method reflection: Kernel#methods, Kernel#singleton_methods (methods were missing in some cases)
      - $~ variable scoping (should be an inner-most non-block scope)
      - inclusion of module already included in a super class was handled incorrectly


More information about the Ironruby-core mailing list