[Ironruby-core] Code Review: rakefix1

Jim Deville jdeville at microsoft.com
Fri Nov 7 15:04:22 EST 2008


Looks good!


JD


> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Seo Sanghyeon
> Sent: Thursday, November 06, 2008 11:57 PM
> To: ironruby-core at rubyforge.org
> Subject: [Ironruby-core] Code Review: rakefix1
>
> Attached patch fixes (well, at least a bit of) Rake build. In
> particular, this patch fixes get_case_sensitive_path to actually work.
> Current code does p.downcase.to_s == filename, which assumes filename
> is already downcased, but filename is from *.csproj and it actually is
> not, so at least it should be p.downcase == filename.downcase. Current
> code also does not deal with directory names differing in case.
>
> --
> Seo Sanghyeon


More information about the Ironruby-core mailing list