[Ironruby-core] Code Review: WEBrick

Tomas Matousek Tomas.Matousek at microsoft.com
Sun May 25 12:28:28 EDT 2008


I forgot to check the result, will fix that.
Thanks for finding this.

Tomas

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Peter Bacon Darwin
Sent: Sunday, May 25, 2008 5:26 AM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] Code Review: WEBrick

Hi Tomas,

What happens if someone calls TCPServer.Accept() without calling
TCPServer#CreateReadWaitHandle() first?

[The new implementation of Accept method needs a WaitHandle to have been
created. It seems that the only time this occurs is when RubyIO.Select() is
called.]

Pete

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org
[mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Tomas Matousek
Sent: Sunday,25 May 25, 2008 00:19
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: [Ironruby-core] Code Review: WEBrick

tfpt review "/shelveset:WEBrick;REDMOND\tomat"

Implements IO.select, String#to_f, Thread#kill, Thread#start,
Thread#inspect, fixes TCPServer, File::Constants, and some other minor
fixes.

Tomas

_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core


More information about the Ironruby-core mailing list