[Ironruby-core] Code Review: RubyArrayPack

Tomas Matousek Tomas.Matousek at microsoft.com
Wed May 21 18:24:27 EDT 2008

What is MRI behavior if I return a number that doesn't fit in sbyte?

writer.Write((sbyte)Protocols.CastToFixnum(context, self[i + j]));

Does it silently overflow? If so, we should use unchecked() region.

Other than that looks good.


-----Original Message-----
From: Curt Hagenlocher
Sent: Wednesday, May 21, 2008 3:15 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: RubyArrayPack

tfpt review /shelveset:RubyArrayPack;REDMOND\curth

Significant subset of Array.pack and String.unpack

Curt Hagenlocher
curth at microsoft.com

More information about the Ironruby-core mailing list