[Ironruby-core] Code Review: Accessors

John Lam (IRONRUBY) jflam at microsoft.com
Wed May 21 01:04:32 EDT 2008

I'm wondering why SetInstanceVariable() has the funny signature:

public static object SetInstanceVariable(object self, object value, CodeContext/*!*/ context, SymbolId name) {

which is quite unlike other method signatures that we're used to seeing.

Otherwise, looks good!

> -----Original Message-----
> From: Tomas Matousek
> Sent: Tuesday, May 20, 2008 7:14 PM
> To: IronRuby External Code Reviewers
> Cc: ironruby-core at rubyforge.org
> Subject: Code Review: Accessors
> tfpt review /shelveset:Accessors;REDMOND\tomat
> Fixes bug #20242: send attr_accessor.
> Uses rule generators to implement attribute accessors. Previously both
> used RubyMethodGroupInfo that was hacked to make them work. The hack is
> not needed anymore.
> Tomas

More information about the Ironruby-core mailing list