[Ironruby-core] Code Review: Reflection

Tomas Matousek Tomas.Matousek at microsoft.com
Thu May 8 20:28:10 EDT 2008


Thanks, forgot about that one.

Tomas

-----Original Message-----
From: Dino Viehland
Sent: Thursday, May 08, 2008 5:12 PM
To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers
Subject: RE: Code Review: Reflection

I think you also need to check for ci.IsFamilyAndAssembly in RubyTypeBuilder.MakeClass (when checking for private) but otherwise it looks good.

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Tomas Matousek
Sent: Thursday, May 08, 2008 11:57 AM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: [Ironruby-core] Code Review: Reflection

tfpt review /shelveset:Reflection;REDMOND\tomat

Removes singleton classes from Module#ancestors return value to match MRI.
Implements Kernel#extend, Kernel#singleton_methods, Module#extended and Module#extend_object.

Fixes [#20002] singleton_methods not implemented.
Fixes [#19972] Module::module_function assertion error. The assertion was incorrect.
Fixes [#20011] Can't subclass module. Added protected constructors to allow inheriting in Ruby.

Includes adjusted Wayne Kelly's patch.

Tomas



More information about the Ironruby-core mailing list