[Ironruby-core] Code Review: bugfixes9

John Lam (IRONRUBY) jflam at microsoft.com
Fri May 2 14:38:51 EDT 2008


tfpt review /shelveset:bugfixes9;REDMOND\jflam

Ruby only bug fixes:

Passes all local tests.

#19804: Inheriting from Numeric
- added a default ctor

#19806: Wrong number or type of arguments for Regexp
- added overloads and trivially implemented Regexp.compile as well
- removed ctor for Regexp that takes a string - not necessary because we have implicit conversion operator for MutableString to String

#19887: Array#reverse_each not implemented
- implemented and verified that all specs pass

#19893: String#ljust not implemented
- implemented ljust - all specs pass
- also trivially implemented rjust - all specs pass

#19842: undef_method overload
- added overload that accepts a string

#19891: Module comparison methods unimplemented
- implemented <, <=, >, >=, <=> - all specs pass

#19845: syntax error - unexpected BLOCK_DO
- fixed by patch #19880

Patches applied:

#19879: Implements the RUBY_ENGINE constant (Michael Letterle)

#19880: Fix for Parser CmdArg bug #19845

Thanks,
-John

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bugfixes9.diff
Type: application/octet-stream
Size: 146775 bytes
Desc: bugfixes9.diff
URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080502/663d93d4/attachment-0001.obj>


More information about the Ironruby-core mailing list