[Ironruby-core] Code Review: YamlRange

Oleg Tkachenko olegtk at microsoft.com
Mon Jun 30 14:13:58 EDT 2008


After F2F check with Tomas we figured out the CodeContext is still needed here.

--
Oleg


-----Original Message-----
From: Tomas Matousek
Sent: Friday, June 27, 2008 6:32 PM
To: Oleg Tkachenko; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: YamlRange

Why not to add Range constructor w/o CodeContext instead? The context is used only to compare bounds. Does YAML actually invoke <=> method when constructing range?

Tomas

-----Original Message-----
From: Oleg Tkachenko
Sent: Friday, June 27, 2008 5:01 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: YamlRange


tfpt review "/shelveset:YamlRange;REDMOND\olegtk"
Comment  :
  Fixes Range support: implements taguri() and loading Range object from yaml.
  Changes constructors to hold a reference to a code context instead of EqualityComparer (Range constructors wants it).

--
Oleg


More information about the Ironruby-core mailing list