[Ironruby-core] Code Review: YamlParse

Oleg Tkachenko olegtk at microsoft.com
Thu Jun 26 16:21:59 EDT 2008


Can you please explain [NotNull]BigInteger part? I mean why [NotNull]?

--
Oleg


-----Original Message-----
From: Tomas Matousek
Sent: Thursday, June 26, 2008 10:51 AM
To: Oleg Tkachenko; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: YamlParse

parse_documents needs to call block.BlockJumped after the block invocation. Also the result of the block invocation should be returned from the function if the block jumped (try parse_documents ... { break 'foo' } and parse_documents ... { 'bar' }).

YAMLNumericOps.TagUri: it is better to define overloads for float, double, decimal, [NotNull]BigInteger and object than switching over the types by hand.

Other than that looks good.

Tomas

-----Original Message-----
From: Oleg Tkachenko
Sent: Wednesday, June 25, 2008 9:16 AM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: YamlParse

tfpt review "/shelveset:YamlParse;REDMOND\olegtk"
Comment  :
  Implements Bignum support.
  Refactores constructors hierarchy by decoupling constructors (those building Ruby objects from Nodes) and composers (those building Nodes from Yaml source) and introducing NodeProvider to be used by contructors.
  Adds preliminary support for YamlNode and Implements YamlNode.transform.
  Implements YAML::parse, YAML::parse_documents and YAML::parse_file methods.
  Removes YamlDocument class - duplicate functionality.

--
Oleg


More information about the Ironruby-core mailing list