[Ironruby-core] Code Review: partial1

Jim Deville jdeville at microsoft.com
Thu Jun 26 16:22:47 EDT 2008


What's the timeout for generic tests? Is it the one in the test? Or does Snap have a limit?


JD


> -----Original Message-----
> From: Srivatsn Narayanan
> Sent: Thursday, June 26, 2008 11:11 AM
> To: Jim Deville; IronRuby External Code Reviewers
> Cc: ironruby-core at rubyforge.org
> Subject: RE: RE: Code Review: partial1
>
> Looks good. Make sure that the generic test won't timeout since the
> running time has effectively doubled. Also, in the batch file, you
> could use pushd %ROWAN_BIN% and then popd instead of storing CURRENT.
>
> -----Original Message-----
> From: Jim Deville
> Sent: Thursday, June 26, 2008 10:57 AM
> To: Srivatsn Narayanan; IronRuby External Code Reviewers
> Cc: ironruby-core at rubyforge.org
> Subject: RE: Code Review: partial1
>
> Fixed. Try again.
>
>
> JD
>
>
> > -----Original Message-----
> > From: Srivatsn Narayanan
> > Sent: Thursday, June 26, 2008 10:41 AM
> > To: Jim Deville; IronRuby External Code Reviewers
> > Cc: ironruby-core at rubyforge.org
> > Subject: RE: Code Review: partial1
> >
> > Did you forget to include irtest.bat? I don't see it already checked
> > in. Also RowanTest.* files don't have any changes. You can undo them.
> >
> > -----Original Message-----
> > From: Jim Deville
> > Sent: Thursday, June 26, 2008 9:10 AM
> > To: IronRuby External Code Reviewers; Srivatsn Narayanan
> > Cc: ironruby-core at rubyforge.org
> > Subject: Code Review: partial1
> >
> > tfpt review "/shelveset:partial1;REDMOND\jdeville"
> > Comment  :
> >   Run IronRuby.test.exe under regular and partial trust in snap.
> >



More information about the Ironruby-core mailing list